Fix Cheerio type error after upgrading to v1.1.2 - #17
Draft
joshspicer with Copilot wants to merge 2 commits into
Draft
Fix Cheerio type error after upgrading to v1.1.2#17joshspicer with Copilot wants to merge 2 commits into
joshspicer with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Copilot instructions document
Fix Cheerio type error after upgrading to v1.1.2
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a TypeScript compilation error introduced after upgrading Cheerio to v1.1.2 (#11).
Problem
The
Cheerio<T>type in Cheerio v1.x is now a generic class that requires a type parameter, but the codebase was using the old API without providing one:This resulted in the following build error:
Solution
Updated the type annotation to include the required generic parameter by:
AnyNodetype from thedomhandlerpackage (which is already a dependency of Cheerio)cheerio.Cheerio<AnyNode>Testing
Original prompt
Created from VS Code via the GitHub Pull Request extension.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.