Skip to content

[vWIP] expand Network fixtures for consistent test setup - #1257

Open
SatvikSaluja wants to merge 2 commits into
jonescompneurolab:masterfrom
SatvikSaluja:test-expand-network-fixtures
Open

[vWIP] expand Network fixtures for consistent test setup#1257
SatvikSaluja wants to merge 2 commits into
jonescompneurolab:masterfrom
SatvikSaluja:test-expand-network-fixtures

Conversation

@SatvikSaluja

@SatvikSaluja SatvikSaluja commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

This PR expands the Network fixtures in conftest.py to support multiple network configurations (default, no drives, small mesh, and 3x3 mesh).

It also introduces a shared default_params fixture to avoid duplicated parameter-loading logic.

Part of #1118.

@asoplata

Copy link
Copy Markdown
Collaborator

Please see my comment #1247 (comment)

@asoplata asoplata closed this Mar 20, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in HNN Workspace Turbo 9000 Mar 20, 2026
@SatvikSaluja
SatvikSaluja deleted the test-expand-network-fixtures branch May 3, 2026 05:17
@asoplata

Copy link
Copy Markdown
Collaborator

Hello Satvik,

Since we did not receive a GSOC contributor for our test-refactoring project, I would like to "reactivate" the three PRs that you made that began some of the work, including #1247, #1251, and #1257. You would not be obligated to continue contributing to them since you'll be working on the Synapse project, but this way you still get credit for the work you've already done on them.

Would you please recreate the branch used for this PR (test-expand-network-fixtures) and push to your origin, so that I can reopen this PR? If you deleted your local copy of the branch, that's fine, you can checkout a version I saved here on my own fork https://github.com/asoplata/hnn-core/tree/test-expand-network-fixtures . I recommend that you add my fork as a remote in your local git install, fetch my branches, checkout that specific branch, make a new branch of the same name, then push that new branch to your origin. I believe that will enable us to reopen this PR.

@SatvikSaluja
SatvikSaluja restored the test-expand-network-fixtures branch May 21, 2026 17:22
@asoplata asoplata reopened this May 22, 2026
@SatvikSaluja SatvikSaluja changed the title TEST: expand Network fixtures for consistent test setup [WIP] expand Network fixtures for consistent test setup May 25, 2026
@SatvikSaluja SatvikSaluja changed the title [WIP] expand Network fixtures for consistent test setup [vWIP] expand Network fixtures for consistent test setup May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants