Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Blazor WebAssembly experience to surface an Android native app option (Google Play) alongside the existing Windows app, and adds a dedicated “native apps” landing page in the repo docs. It also includes several build and lifecycle-management changes that go beyond the PR title’s scope.
Changes:
- Add Google Play Store link/badge in the WebAssembly loading footer and in
README.md, plus a newdocs/native-apps.mdlanding page. - Adjust WebAssembly build settings/dependencies (SPA fallback enabled; DevServer dependency replaced with
Microsoft.AspNetCore.Components.Gateway; PatchCoreLib imported into Worker WASM project). - Change
CommitHashViewtoIAsyncDisposableand update disposal logic; minor cleanup removing an unused using.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WorkerWebAssembly/WorkerWebAssembly.csproj | Imports PatchCoreLib build targets for the Worker WASM project. |
| src/WebAssembly/WebAssembly.csproj | Adds Android link in loading footer; enables SPA fallback; changes build-time package reference. |
| src/WebAssembly/Program.cs | Points the “DesktopAppLink” UI entry to the new native-apps doc page. |
| src/App/Lab/CommitHashView.razor | Switches to IAsyncDisposable and changes lock disposal behavior. |
| src/App/App.cs | Removes unused Microsoft.JSInterop using. |
| README.md | Adds Android Play Store link and badge alongside Windows + Web. |
| eng/PatchCoreLib.targets | Refactors target ordering/conditions for CoreLib patching and makes patching conditional. |
| docs/native-apps.md | New doc page listing native app store links/badges. |
| Directory.Packages.props | Adds central version for Microsoft.AspNetCore.Components.Gateway; removes DevServer package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.