Skip to content

Fix for pre,post,prelink commands , relative includes and other fixes to make it more similar to how premake gmake2 works.#35

Closed
LostbBlizzard wants to merge 10 commits into
jimon:masterfrom
LostbBlizzard:master
Closed

Fix for pre,post,prelink commands , relative includes and other fixes to make it more similar to how premake gmake2 works.#35
LostbBlizzard wants to merge 10 commits into
jimon:masterfrom
LostbBlizzard:master

Conversation

@LostbBlizzard

Copy link
Copy Markdown
Contributor
  • Fixed defualtplatform not using defualtplatform when set.
  • Fixed prebuild commands runing even when its project dependencies are not built.
  • Fixed project c and c++ includes not being relative to the location property.
  • Fixed project pre,post,prelink not runing in the working working directory of location property.

I havent updated forceincludes because i didn't use them in project and this pull request is a bit messy.I will fix it after this pull request.

@Jarod42

Jarod42 commented Oct 13, 2024

Copy link
Copy Markdown
Collaborator

Can you split the PR by fix?

Paths (as includedirs) from toolset should be fixed now when workspace location != project location.
pre/post build command might still be an issue though.
UTs fail, I didn't check if issue come from core or your PR.

@LostbBlizzard

Copy link
Copy Markdown
Contributor Author

I'll spit PR when I get home. Sorry I didn't see the message till today.

@LostbBlizzard

LostbBlizzard commented Oct 19, 2024

Copy link
Copy Markdown
Contributor Author

pull request was split

Theses one more fix but depends on fixed missing prefix in getFileDependencies see #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants