This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Out of repo settings - #69
Open
cyisfor wants to merge 1 commit into
Open
Conversation
Files that contain private information like passwords, secrets, and host names shouldn't be under revision control.
Owner
|
Hi, thank you for all of your help. I'm currently -1 on this patch, though I like the idea. I feel like using XDG directories is too focused on the use case of an individual running it as a client on their personal computer, rather than for people running public servers. I think the most Django-ish way of doing it would be to look for a file like 'local_settings.py' in the same folder as settings.py. |
|
I'm just a regular user so my opinion doesn't matter that much on this topic... but agree with @jfmcbrayer. Something closer to https://12factor.net/config is much more preferable than storing settings on XDG Directories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we don't accidenally put passwords under revision control.