G so c m1.7.7#119
Open
jayam04 wants to merge 53 commits into
Open
Conversation
…licking button (oppia#25783) * add stability guards and retry to saveProgress * Fixing Lint errors * wait for save-progress tooltip to clear before clicking to fix .save-progress-btn flake * Adressing review comments * Add TODO tracking frontend bug for save progress tooltip
…main_test (oppia#26384) * Fix part of oppia#15106: Reduce unnecessary Optional fields in ModifiableUserDataDict * Fix part of oppia#15106: Remove unnecessary Optional fields from language properties in ModifiableUserDataDict and fix tests * Fix part of oppia#15106: Update MockModifiableUserData language annotations for strict str compatibility * Fix Mypy type annotations in user_domain_test.py * chore: trigger CI rebuild due to GitHub Actions error
…ations (oppia#26265) * Fix oppia#26148: Resolve Arabic cursive text rendering in MathJax equations * Fix oppia#26148: Resolve Arabic cursive text rendering in MathJax equations * Address review comments: Add CTL rationale comment and update copyright * Add E2E test to verify Arabic MathJax CTL rendering in SVG text nodes * Refactor MathJax E2E tests to address reviewer feedback * Refactor MathJax E2E tests based on Jayam04 feedback * Fix oppia#26148: Scope MathJax DOM query to active modal * Moving Constant on Top and using null * Fix TypeScript syntax error from web editor merge resolution
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…e modal designs (oppia#26302) * Add linter check and allowlist for standardizing modal designs * Fixig tests * Fighting with lint * Addressing review comments * Added new file in allowlist * Updated checks * Fixed path and backdrop regex matching * Fixed lint * Added new files to allowlist * fixed lint
…er/reaches-a-checkpoint-and-saves-their-progress to playwright (oppia#26344) * Setting up playwright node * Implemented M1.2 and M1.3 and M1.4 * Moved common mocks to setUp * Migrated add-and-remove-exploration to playwright * Exclude playwright acceptance tests from frontend test runner * Removed puppeteer spec * Exclude playwright directory in root-files-mapping-generator * Exclude playwright-acceptance-tests from root TS and Karma configs * Migrated completes-the-exploration... to playwright * Migrated sets-goal-on-learner-dashboard to playwright * Migrated provide-feedback * fixed flake * testing * testing * testing * removing unnecessary log * removing unnecessary log * Migrated access-pages-that-require-higher-privileges * Migrated goes-through-the-sign-in-flow * Migrated reaches-a-checkpoint * Fixing lint errors * Fixing lint * Fix errors * Fixing lint * Merge GSoC-M1.7.5 into GSoC-M1.7.6 * Removed global
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
the cause of the bug was, and which PR introduced it]
Essential Checklist
Please follow the instructions for making a code change.
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers