Add 50 tests for controllers#884
Open
eugeniomiro wants to merge 1 commit into
Open
Conversation
(cherry picked from commit 75f4e5b)
Contributor
Author
|
Hi @willdean, I sent this PR 11 days ago do you think it's useful? Is there anything you want me to do with it to be able to merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @willdean, this PR (fixing failed #883) contains a set of tests for Controllers that don't modify any server code, just adds test code.
All Tests pass
I started this time from master with all commits squashed as we discussed before.