Store the actual domain username in the user model#795
Open
cbaerike wants to merge 1 commit into
Open
Conversation
…ay include a different domain name.
Author
|
Just saw issue #738 - this PR will fix it. |
|
Hello! Any reason why this hasn't been merged yet? |
Collaborator
|
Unfortunately this is the kind of change seems almost certain to break something in the very complex matrix of different auth permutations, many of which I'm not actually able to test here. For example, I am somewhat sceptical that Something more adaptable is probably needed here, though I'm not really sure what. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change includes 2 things: