Add coverage for useViewportOffset hook behavior - #16
Merged
Conversation
Agent-Logs-Url: https://github.com/itsubaki/bloch/sessions/320862b5-e8b1-4454-9c70-95e9aeedfbf8 Co-authored-by: itsubaki <1759459+itsubaki@users.noreply.github.com>
Agent-Logs-Url: https://github.com/itsubaki/bloch/sessions/320862b5-e8b1-4454-9c70-95e9aeedfbf8 Co-authored-by: itsubaki <1759459+itsubaki@users.noreply.github.com>
Agent-Logs-Url: https://github.com/itsubaki/bloch/sessions/320862b5-e8b1-4454-9c70-95e9aeedfbf8 Co-authored-by: itsubaki <1759459+itsubaki@users.noreply.github.com>
Agent-Logs-Url: https://github.com/itsubaki/bloch/sessions/320862b5-e8b1-4454-9c70-95e9aeedfbf8 Co-authored-by: itsubaki <1759459+itsubaki@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 9 +1
Lines 63 77 +14
Branches 11 12 +1
=========================================
+ Hits 63 77 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds focused tests for
hooks/use-viewport-offset.tsto cover the hook’s viewport-driven state updates and fallback behavior. The new coverage exercises the cases most likely to regress whenvisualViewportis absent or when mobile viewport metrics change.Hook coverage
use-viewport-offset.test.tsx0whenwindow.visualViewportis unavailableinnerHeight,visualViewport.height, andoffsetTopViewport event behavior
resizeandscrollevents fire0Lifecycle behavior
Mocking approach
visualViewportwith explicit listener registration and dispatch to keep the tests deterministic and close to the browser API surface