Skip to content

Add the support on clock_skew_seconds in request authentication #3710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
freedomljc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add the support on clock_skew_seconds in request authentication #3710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions kubernetes/customresourcedefinitions.gen.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions releasenotes/notes/jwt-clock-skew-seconds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
apiVersion: release-notes/v2
kind: feature
area: security
issue:
- https://github.com/istio/istio/issues/60259

releaseNotes:
- |
**Added** `clockSkewSeconds` field in `RequestAuthentication` under `spec.jwtRules.` to configure the
clock skew tolerance (in seconds) applied when validating the JWT `exp` and `nbf` claims. When unset,
the previous default of 60 seconds is preserved.
19 changes: 15 additions & 4 deletions security/v1beta1/request_authentication.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions security/v1beta1/request_authentication.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion security/v1beta1/request_authentication.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,8 +487,12 @@ message JWTRule {
// +kubebuilder:validation:MaxItems=64
repeated string space_delimited_claims = 14;

// The clock skew, in seconds, allowed when verifying the JWT `exp` and `nbf`
// claims. If not specified, the default is 60 seconds.
uint32 clock_skew_seconds = 15;

// $hide_from_docs
// Next available field number: 15
// Next available field number: 16
}

// This message specifies a header location to extract JWT token.
Expand Down