-
Notifications
You must be signed in to change notification settings - Fork 9.5k
fix(agent): skip empty switch conditions #15691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+60
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| from agent.component.switch import Switch, SwitchParam | ||
|
|
||
|
|
||
| class _Canvas: | ||
| def __init__(self, variables=None): | ||
| self.variables = variables or {} | ||
|
|
||
| def is_canceled(self): | ||
| return False | ||
|
|
||
| def get_variable_value(self, cpn_id): | ||
| return self.variables[cpn_id] | ||
|
|
||
| def get_component_name(self, cpn_id): | ||
| return cpn_id | ||
|
|
||
|
|
||
| def _switch(param, variables=None): | ||
| cpn = Switch.__new__(Switch) | ||
| cpn._canvas = _Canvas(variables) | ||
| cpn._id = "switch" | ||
| cpn._param = param | ||
| return cpn | ||
|
|
||
|
|
||
| def test_switch_empty_condition_falls_through_to_else(): | ||
| param = SwitchParam() | ||
| param.conditions = [ | ||
| { | ||
| "logical_operator": "and", | ||
| "items": [{"cpn_id": "", "operator": "=", "value": "yes"}], | ||
| "to": ["case_target"], | ||
| } | ||
| ] | ||
| param.end_cpn_ids = ["else_target"] | ||
|
|
||
| cpn = _switch(param) | ||
| cpn._invoke() | ||
|
|
||
| assert cpn.output("_next") == ["else_target"] | ||
| assert cpn.output("next") == ["else_target"] | ||
|
|
||
|
|
||
| def test_switch_non_empty_and_condition_still_matches(): | ||
| param = SwitchParam() | ||
| param.conditions = [ | ||
| { | ||
| "logical_operator": "and", | ||
| "items": [{"cpn_id": "answer", "operator": "=", "value": "yes"}], | ||
| "to": ["case_target"], | ||
| } | ||
| ] | ||
| param.end_cpn_ids = ["else_target"] | ||
|
|
||
| cpn = _switch(param, {"answer": "yes"}) | ||
| cpn._invoke() | ||
|
|
||
| assert cpn.output("_next") == ["case_target"] | ||
| assert cpn.output("next") == ["case_target"] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add pytest priority markers to test functions.
Both test functions are missing priority markers (
@pytest.mark.p1,@pytest.mark.p2, or@pytest.mark.p3). As per coding guidelines, all tests intest/**/*.pyshould use pytest priority markers.📝 Proposed fix to add priority markers
+@pytest.mark.p1 def test_switch_empty_condition_falls_through_to_else(): param = SwitchParam()+@pytest.mark.p1 def test_switch_non_empty_and_condition_still_matches(): param = SwitchParam()Also applies to: 44-59
🤖 Prompt for AI Agents