removes UI for managing curriculum inventory reports. - #9449
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Visual Diff Report — PASSED984 images compared: 984 identical Download the results. |
c792b2a to
7dfa884
Compare
7dfa884 to
5e1d38e
Compare
michaelchadwick
left a comment
There was a problem hiding this comment.
I found some more instances of CIR that should probably be taken out:
rg -w "curriculum inventory"
packages/frontend/translations/en-us.yaml
47: canNotDeleteProgram: This program cannot be deleted because it is attached to a curriculum inventory report or program year, or you do not have permission.
packages/frontend/tests/acceptance/four-oh-four-test.js
134: test('visiting missing curriculum inventory report #6324', async function (assert) {
packages/test-app/tests/unit/serializers/curriculum-inventory-export-test.js
4:module('Unit | Serializer | curriculum inventory export', function (hooks) {
packages/test-app/tests/unit/serializers/curriculum-inventory-report-test.js
4:module('Unit | Serializer | curriculum inventory report', function (hooks) {
packages/test-app/tests/unit/serializers/curriculum-inventory-sequence-block-test.js
4:module('Unit | Serializer | curriculum inventory sequence block', function (hooks) {
That first one should probably change from canNotDeleteProgram: This program cannot be deleted because it is attached to a curriculum inventory report or program year, or you do not have permission. to canNotDeleteProgram: This program cannot be deleted because it is attached to a program year, or you do not have permission.
interesting point. the given reason as stated will still hold true - we're keeping the CIR data and its relationships around. might need to defer to Sascha on this. |
Oops, missed that part. Didn't realize we were not going scorched earth. So, not sure now. |
|
Staging build deployed! It can be accessed with |
2 similar comments
|
Staging build deployed! It can be accessed with |
|
Staging build deployed! It can be accessed with |
fixes ilios/ilios#7301
this removes any curriculum inventory report management related code but models and associates (tests/serializers) from the frontend.