Skip to content

Course Overview item re-ordering so dates are always adjacent - #9401

Draft
michaelchadwick wants to merge 1 commit into
ilios:masterfrom
michaelchadwick:frontend-7213-course-overview-bits-reorg
Draft

Course Overview item re-ordering so dates are always adjacent#9401
michaelchadwick wants to merge 1 commit into
ilios:masterfrom
michaelchadwick:frontend-7213-course-overview-bits-reorg

Conversation

@michaelchadwick

Copy link
Copy Markdown
Contributor

Fixes ilios/ilios#7213

Desktop
desktop

Tablet to Desktop
tablet_to_desktop

Phone to Tablet
phone_to_tablet

Phone
phone

@netlify

netlify Bot commented Jun 24, 2026

Copy link
Copy Markdown

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit e4d740d
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/6a46db93394ff80007939ba4
😎 Deploy Preview https://deploy-preview-9401--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

❌ Visual Diff Report — FAILED

984 images compared: 276 different · 708 identical

Details

Differences (276)

File Diff % Notes
desktop-Acceptance _ Course - Cohorts _ manage cohorts _ .png 0.13%
desktop-Acceptance _ Course - Competencies _ collapsed competencies renders _ .png 0.14%
desktop-Acceptance _ Course - Leadership _ collapsed leadership _ .png 0.14%
desktop-Acceptance _ Course - Leadership _ list leadership _ .png 0.15%
desktop-Acceptance _ Course - Learning Materials _ list double linked learning materials _ .png 0.15%
desktop-Acceptance _ Course - Multiple Objective Parents _ initial view _ .png 0.12%
desktop-Acceptance _ Course - Objective List _ list objectives _ .png 0.10%
desktop-Acceptance _ Course - Objective List _ long objective _ .png 0.12%
desktop-Acceptance _ Course - Objective Mesh Descriptors _ cancel changes _ default background color.png 0.13%
desktop-Acceptance _ Course - Objective Mesh Descriptors _ cancel changes _ managed background color.png 0.13%
desktop-Acceptance _ Course - Objective Mesh Descriptors _ manage terms _ default background color.png 0.13%
desktop-Acceptance _ Course - Objective Mesh Descriptors _ manage terms _ managed background color.png 0.13%
desktop-Acceptance _ Course - Objective Mesh Descriptors _ save terms _ default background color.png 0.13%
desktop-Acceptance _ Course - Objective Mesh Descriptors _ save terms _ managed background color.png 0.13%
desktop-Acceptance _ Course - Objective Parents _ cancel changes _ default background color.png 0.13%
desktop-Acceptance _ Course - Objective Parents _ cancel changes _ managed background color.png 0.12%
desktop-Acceptance _ Course - Objective Parents _ save changes _ objective list.png 0.13%
desktop-Acceptance _ Course - Objective Parents _ save changes _ objective manager.png 0.12%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 1st objective list item collapsed again.png 0.11%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 1st objective list item collapsed.png 0.11%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 1st objective list item expanded.png 0.09%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 2nd objective list item collapsed again.png 0.11%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 2nd objective list item collapsed.png 0.11%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 2nd objective list item expanded.png 0.05%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 3rd objective list item collapsed again.png 0.11%
… and 251 more

Download the results.

@jrjohnson

Copy link
Copy Markdown
Member

Code is an easy review, would like to get @dartajax's take first.

@stopfstedt

Copy link
Copy Markdown
Member

Code is an easy review, would like to get @dartajax's take first.

Sascha added it as an item to review for tomorrow's meeting.

@michaelchadwick

Copy link
Copy Markdown
Contributor Author

Slapped a DO NOT MERGE on it for now

@dartajax dartajax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest with you, the whole thing could use a re-work but this is indeed an improvement - I have never liked seeing start and and end date on different lines so ... I approve

@michaelchadwick

michaelchadwick commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Start/End Date should not be at the bottom. "Overview" header probably not needed. When re-thinking this, consider hierarchy of items:

  1. Course ID and Start Date/End Date
  2. Level
  3. Clerkship
  4. Universal Locator

@michaelchadwick
michaelchadwick marked this pull request as draft June 30, 2026 16:53
@michaelchadwick
michaelchadwick force-pushed the frontend-7213-course-overview-bits-reorg branch from 834fcbe to e4d740d Compare July 2, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rearrange Course Start/End Date for better flow

4 participants