Skip to content

added a parenthetical course and status to 'back to session list' link - #9128

Draft
michaelchadwick wants to merge 3 commits into
ilios:masterfrom
michaelchadwick:frontend-6846-better-back-to-session-label
Draft

added a parenthetical course and status to 'back to session list' link#9128
michaelchadwick wants to merge 3 commits into
ilios:masterfrom
michaelchadwick:frontend-6846-better-back-to-session-label

Conversation

@michaelchadwick

@michaelchadwick michaelchadwick commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Fixes ilios/ilios#6846

Screenshot 2026-02-06 at 10 06 40 AM

Adds a parenthetical label to the Back to Session List link at the top of a session detail route. It contains the Course externalId if existing, otherwise the title. It also has the icon for the Course's publication status.

@netlify

netlify Bot commented Feb 6, 2026

Copy link
Copy Markdown

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit eac1f19
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/698f60d2881de40008bea0b7
😎 Deploy Preview https://deploy-preview-9128--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

❌ Visual Diff Report — FAILED

984 images compared: 124 different · 860 identical

Details

Differences (124)

File Diff % Notes
desktop-Acceptance _ Session - Leadership _ collapsed leadership _ .png 0.04%
desktop-Acceptance _ Session - Learning Materials _ list learning materials _ .png 0.04%
desktop-Acceptance _ Session - Objective List _ list objectives _ .png 0.02%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ cancel changes _ default background color.png 0.04%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ cancel changes _ managed background color.png 0.03%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ manage terms _ default background color.png 0.04%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ manage terms _ managed background color.png 0.03%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ save terms _ default background color.png 0.04%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ save terms _ managed background color.png 0.03%
desktop-Acceptance _ Session - Objective Parents _ cancel changes _ default background color.png 0.03%
desktop-Acceptance _ Session - Objective Parents _ cancel changes _ managed background color.png 0.04%
desktop-Acceptance _ Session - Objective Parents _ deselect all parents for session objective _ default background color.png 0.03%
desktop-Acceptance _ Session - Objective Parents _ deselect all parents for session objective _ managed background color.png 0.04%
desktop-Acceptance _ Session - Objective Parents _ list parent objectives _ default background color.png 0.03%
desktop-Acceptance _ Session - Objective Parents _ list parent objectives _ managed background color.png 0.04%
desktop-Acceptance _ Session - Objective Parents _ save changes _ default background color.png 0.03%
desktop-Acceptance _ Session - Objective Parents _ save changes _ managed background color.png 0.04%
desktop-Acceptance _ Session - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 1st objective list item collapsed again.png 0.02%
desktop-Acceptance _ Session - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 1st objective list item collapsed.png 0.02%
desktop-Acceptance _ Session - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 1st objective list item expanded.png 0.02%
desktop-Acceptance _ Session - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 2nd objective list item collapsed again.png 0.02%
desktop-Acceptance _ Session - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 2nd objective list item collapsed.png 0.02%
desktop-Acceptance _ Session - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 2nd objective list item expanded.png 0.02%
desktop-Acceptance _ Session - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 3rd objective list item collapsed again.png 0.02%
desktop-Acceptance _ Session - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 3rd objective list item collapsed again(1).png 0.02%
… and 99 more

Download the results.

@michaelchadwick
michaelchadwick marked this pull request as ready for review February 6, 2026 19:35
@dartajax

dartajax commented Feb 6, 2026

Copy link
Copy Markdown
Member

Tagged for team discussion so we can do exactly that - about whether the added stuff to the session list link area is helping or hindering and what exactly should be there if anything.

@stopfstedt stopfstedt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected component reusage, i love it. LGTM.

@jrjohnson
jrjohnson removed their request for review February 10, 2026 17:53
@stopfstedt

Copy link
Copy Markdown
Member

notes from today's team discussion on this:

  1. Remove parenthesis
  2. Move publication icon to the left
  3. Move the back link behind the course name
  4. Little bit of space between.
  5. possibly add an icon to back to sessions list.

for comparison - a rough "mockup" of these requested changes.

image

vs

image

@dartajax dartajax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality review only - click tested - I'd recommend that @saschaben review this too

@dartajax

Copy link
Copy Markdown
Member

any way to land here ...?
image

rather than ...?
image

New ticket or future enhancement maybe.

@michaelchadwick

Copy link
Copy Markdown
Contributor Author

@dartajax The scroll amount could be adjusted, yes, but in a new PR.

@dartajax

Copy link
Copy Markdown
Member

@dartajax The scroll amount could be adjusted, yes, but in a new PR.

Fair enough.

@michaelchadwick
michaelchadwick force-pushed the frontend-6846-better-back-to-session-label branch from 90d0c67 to eac1f19 Compare February 13, 2026 17:35
@dartajax
dartajax requested a review from saschaben February 13, 2026 18:45

@stopfstedt stopfstedt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dartajax

Copy link
Copy Markdown
Member

Although there has been plenty of discussion on this PR and what I am going to input here was originally going to be added in a separate ticket. This is the bit about getting the screen to scroll to something like the following or what I pasted in 5 days ago.

image

Basically, none of the "Show Details" should be visible including the bottom border but ... right below it is where we should scroll to if possible.

@michaelchadwick
michaelchadwick marked this pull request as draft February 17, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

frontend - session management - provide additional course context on the "Back to sessions" link

4 participants