Skip to content

[codex] Fix Sonar accessibility and test findings#160

Merged
igorsatsyuk merged 2 commits into
mainfrom
fix/sonar-findings-cleanup
Jun 15, 2026
Merged

[codex] Fix Sonar accessibility and test findings#160
igorsatsyuk merged 2 commits into
mainfrom
fix/sonar-findings-cleanup

Conversation

@igorsatsyuk

Copy link
Copy Markdown
Owner

What changed

  • fixed Sonar-reported accessibility issues in the Angular audit dashboard and login form by adding explicit input identifiers and labels
  • replaced deprecated Kafka JSON serializer usage and preserved producer override binding behavior in command-service
  • removed test reliance on the system clock and replaced flagged numeric month literals in backend tests

Why

These changes clean up the Sonar findings shown in the report without changing product behavior, while keeping the Kafka producer configuration and test suite stable.

Impact

  • fewer accessibility warnings in the frontend templates
  • no deprecated Spring Kafka serializer in command-service
  • more deterministic backend tests

Validation

  • mvn -pl command-service,audit-writer-service,common/shared-contracts,event-store-service,query-service -am "-Dsurefire.failIfNoSpecifiedTests=false" "-Dtest=KafkaProducerConfigIntegrationTest,AuditLedgerContractGanacheTest,BlockchainWriterServiceTest,JwtSecurityComponentsTest,EventPersistenceServiceTest,IntegrityCheckIntegrationTest,AuditEventDtoMapperTest,AuditLogQueryServiceTest" test

@igorsatsyuk igorsatsyuk marked this pull request as ready for review June 15, 2026 18:33
@igorsatsyuk igorsatsyuk merged commit 17a7877 into main Jun 15, 2026
8 checks passed
@igorsatsyuk igorsatsyuk deleted the fix/sonar-findings-cleanup branch June 15, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant