This repository was archived by the owner on Apr 17, 2019. It is now read-only.
Ordering Service: on request proposal strategy - #2215
Open
muratovv wants to merge 23 commits into
Open
Conversation
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
igor-egorov
reviewed
Apr 8, 2019
| */ | ||
|
|
||
| #ifndef IROHA_KICK_OUT_PROPOSAL_CREATION_STRATEGY_HPP | ||
| #define IROHA_KICK_OUT_PROPOSAL_CREATION_STRATEGY_HPP |
Contributor
There was a problem hiding this comment.
IROHA_SUPER_KICK_OUT_MEGA_PROPOSAL_ULTRA_CREATION_STRATEGY_9000_HPP
:D
Contributor
Author
There was a problem hiding this comment.
Could you suggest a more appropriate name?
Contributor
There was a problem hiding this comment.
No, It was not an issue
igor-egorov
approved these changes
Apr 8, 2019
igor-egorov
left a comment
igor-egorov
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Summon @MBoldyrev
| shared_model::validation::Answer answer; | ||
| answer.addReason(std::move(reason)); | ||
| if (answer.hasErrors()) { | ||
| log_->error("Peer key struct isn't parsed, {}", answer.reason()); |
Contributor
There was a problem hiding this comment.
Suggested change
| log_->error("Peer key struct isn't parsed, {}", answer.reason()); | |
| log_->error("Peer key struct was not parsed, {}", answer.reason()); |
lebdron
changed the title
igor-egorov
reviewed
Apr 10, 2019
|
|
||
| /** | ||
| * Separate action required because CollectionType is non-copyable | ||
| * Separate action required because CollectionType is non-copy1able |
Contributor
There was a problem hiding this comment.
Suggested change
| * Separate action required because CollectionType is non-copy1able | |
| * Separate action required because CollectionType is non-copyable |
looks like a typo
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
lebdron
marked this pull request as ready for review
April 14, 2019 17:17
igor-egorov
approved these changes
Apr 15, 2019
| agreed, all, detail::kSupermajorityCheckerKfPlus1Bft); | ||
| } | ||
|
|
||
| bool SupermajorityCheckerBft::hasMajority(PeersNumberType voted, |
Contributor
There was a problem hiding this comment.
Discussed offline: need to rename the method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
The initial intention of the PR is to introduce a strategy for preventing the creation of proposals in OS. But this pr contains dependent changes for the proper working of the strategy.
Benefits
Add round optimization for faster collaboration. Also, Closer to release state.
Possible Drawbacks
A lot of different features which introduce in one PR
List of features
Alternate Designs [optional]
The transport layer is not backward compatible - introduces peer key of the sending side. There is an alternative with meta information in the request.
Drawback
The PR doesn't work because it is blocked by hyperledger-iroha/iroha#2066.