Skip to content
This repository was archived by the owner on Apr 17, 2019. It is now read-only.

OG batch resend strategy - #2207

Open
luckychess wants to merge 6 commits into
developfrom
feature/og_batch_resend_strategy
Open

OG batch resend strategy#2207
luckychess wants to merge 6 commits into
developfrom
feature/og_batch_resend_strategy

Conversation

@luckychess

Copy link
Copy Markdown
Contributor

Description of the Change

Pull request implements strategy for resending batches from cache.

Benefits

We don't resend batches to the rounds we already sent before.

Possible Drawbacks

  • Code complexity
  • Strategy partially intersects with OG cache logic
  • remove function complexity :(

Usage Examples or Tests

Check on_demand_resend_strategy_test

Signed-off-by: Konstantin Munichev <toobwn@gmail.com>
@luckychess
luckychess requested review from MBoldyrev and lebdron April 1, 2019 19:32
Comment thread irohad/ordering/impl/on_demand_connection_manager.cpp Outdated
Comment thread irohad/ordering/impl/ordering_gate_cache/on_demand_resend_strategy.cpp Outdated
Comment thread irohad/ordering/impl/ordering_gate_cache/on_demand_resend_strategy.cpp Outdated
Comment thread irohad/ordering/impl/ordering_gate_cache/on_demand_resend_strategy.cpp Outdated
Comment thread irohad/ordering/impl/ordering_gate_cache/on_demand_resend_strategy.cpp Outdated
Signed-off-by: Konstantin Munichev <toobwn@gmail.com>
Signed-off-by: Konstantin Munichev <toobwn@gmail.com>
Signed-off-by: Konstantin Munichev <toobwn@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants