refactor(dfir_lang): remove stratum, add push codegen for lattice_fold, lattice_reduce, _lattice_fold_batch#2970
Open
MingweiSamuel wants to merge 1 commit into
Open
Conversation
Deploying hydro with
|
| Latest commit: |
9c98e2d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eebd59cb.hydroflow.pages.dev |
| Branch Preview URL: | https://mingwei-newpush-latticefold.hydroflow.pages.dev |
66afb59 to
869360d
Compare
cfdd3bb to
73a8e26
Compare
869360d to
c931247
Compare
73a8e26 to
f170cf6
Compare
c931247 to
622f695
Compare
f170cf6 to
275834c
Compare
b3b3204 to
2e25dc3
Compare
275834c to
5be7095
Compare
2e25dc3 to
59d1ce2
Compare
5f1f6ac to
0177c8e
Compare
18b7869 to
d1ebaa7
Compare
0177c8e to
774fd27
Compare
774fd27 to
fe64bfe
Compare
d1ebaa7 to
080af6c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors DFIR language operator codegen for lattice folding/reducing operators by removing monotone-accum delay barriers and allowing lattice_fold / lattice_reduce to be codegenerated in non-pull contexts, with corresponding updates to graph visualization snapshots in dfir_rs tests.
Changes:
- Remove
DelayType::MonotoneAccuminput delay typing fromlattice_fold,lattice_reduce, and_lattice_fold_batchoperator constraints. - Make
lattice_reducecodegen conditional onis_pull(only inject pull-specific type checks when in pull mode). - Update graphvis Mermaid/DOT snapshots to reflect the simplified graph structure (fewer handoffs / different subgraph clustering) resulting from barrier removal and fusion changes.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dfir_lang/src/graph/ops/lattice_reduce.rs | Removes monotone-accum delay typing and gates pull-only input trait checks behind is_pull. |
| dfir_lang/src/graph/ops/lattice_fold.rs | Removes monotone-accum delay typing and delegates to fold without asserting pull-only mode. |
| dfir_lang/src/graph/ops/_lattice_fold_batch.rs | Removes monotone-accum delay typing for the batch-fold fusion operator (still pull-only). |
| dfir_rs/tests/snapshots/surface_singleton__fold_cross@graphvis_mermaid.snap | Snapshot update reflecting new graph edges/subgraph layout after barrier removal. |
| dfir_rs/tests/snapshots/surface_singleton__fold_cross@graphvis_dot.snap | DOT snapshot update matching the new graph structure. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick@graphvis_mermaid.snap | Snapshot update reflecting handoff/barrier changes in the generated graph. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick@graphvis_dot.snap | DOT snapshot update matching the new graph structure. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick_tee@graphvis_mermaid.snap | Snapshot update reflecting handoff/barrier changes in the generated graph. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick_tee@graphvis_dot.snap | DOT snapshot update matching the new graph structure. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick_identity@graphvis_mermaid.snap | Snapshot update reflecting handoff/barrier changes in the generated graph. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick_identity@graphvis_dot.snap | DOT snapshot update matching the new graph structure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fe64bfe to
efcc46e
Compare
080af6c to
15e1108
Compare
…ld`, `lattice_reduce`, `_lattice_fold_batch` PR: #2970
15e1108 to
9c98e2d
Compare
efcc46e to
d08ff6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.