Skip to content

fix handleError on non-string error.code and serialize object/array data values as json #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anasmadrhar wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix handleError on non-string error.code and serialize object/array data values as json #294

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab6d25e
Guard handleError against non-string error.code
anasmadrhar May 2, 2026
981e5d2
Stringify object/array data values as JSON instead of "[object Object]"
anasmadrhar May 2, 2026
3aee67c
Add regression tests for both bugfixes
anasmadrhar May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion functions/android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,12 @@ module.exports = {

androidNotificationKeys.forEach((key) => {
if (Object.hasOwn(req.body.data, key)) {
payload.data[key] = String(req.body.data[key]);
const v = req.body.data[key];
// FCM data values must be strings. For arrays/objects (e.g. when the
// calling integration's template engine auto-parses a JSON-string
// back into a list), String(value) produces "[object Object]" which
// the receiving app then can't decode as JSON. Stringify properly.
payload.data[key] = (v !== null && typeof v === 'object') ? JSON.stringify(v) : String(v);
Comment on lines +116 to +121
}
});
}
Expand Down
7 changes: 5 additions & 2 deletions functions/handlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,11 @@ function handleError(req, res, payload = {}, step, incomingError, shouldExit = t
incomingError = new Error(incomingError);
}

// Handle Firebase Messaging errors with appropriate status codes
if (incomingError.code?.startsWith('messaging/')) {
// Handle Firebase Messaging errors with appropriate status codes.
// `code` can be a non-string (e.g. numeric HTTP status from a network failure
// before reaching FCM); without the type guard, .startsWith throws and masks
// the underlying error.
if (typeof incomingError.code === 'string' && incomingError.code.startsWith('messaging/')) {
const errorCode = incomingError.code.replace('messaging/', '');

// For specific token errors, skip reporting and return immediately
Expand Down
Loading