Refactor threshold trigger and condition docs into shared includes#45719
Draft
abmantis wants to merge 2 commits into
Draft
Refactor threshold trigger and condition docs into shared includes#45719abmantis wants to merge 2 commits into
abmantis wants to merge 2 commits into
Conversation
home-assistant
Bot
added
in-progress
|
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the “threshold” family of trigger and condition documentation by extracting duplicated UI/YAML explanation blocks into shared includes, and then applying those includes to the temperature and humidity trigger/condition pages.
Changes:
- Introduces reusable include partials for “crossed threshold” and “changed” triggers (UI steps + UI options + YAML options).
- Introduces reusable include partials for “threshold value” conditions (UI steps + UI options + YAML options).
- Updates the temperature and humidity trigger/condition pages to use the new shared includes.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| source/_triggers/temperature.crossed_threshold.markdown | Replaces duplicated UI/YAML option text with shared “crossed threshold” includes (temperature variant). |
| source/_triggers/temperature.changed.markdown | Replaces duplicated UI/YAML option text with shared “changed” includes (temperature variant). |
| source/_triggers/humidity.crossed_threshold.markdown | Replaces duplicated UI/YAML option text with shared “crossed threshold” includes (unitless/humidity variant). |
| source/_triggers/humidity.changed.markdown | Replaces duplicated UI/YAML option text with shared “changed” includes (unitless/humidity variant). |
| source/_conditions/temperature.is_value.markdown | Replaces duplicated UI/YAML option text with shared “threshold value” condition includes (temperature variant). |
| source/_conditions/humidity.is_value.markdown | Replaces duplicated UI/YAML option text with shared “threshold value” condition includes (unitless/humidity variant). |
| source/_includes/triggers/threshold_crossed_steps.md | New shared UI step list for “crossed threshold” triggers. |
| source/_includes/triggers/threshold_crossed_options_ui.md | New shared UI options block for “crossed threshold” triggers. |
| source/_includes/triggers/threshold_crossed_options_yaml.md | New shared YAML options block for “crossed threshold” triggers. |
| source/_includes/triggers/threshold_changed_steps.md | New shared UI step list for “changed” triggers. |
| source/_includes/triggers/threshold_changed_options_ui.md | New shared UI options block for “changed” triggers. |
| source/_includes/triggers/threshold_changed_options_yaml.md | New shared YAML options block for “changed” triggers. |
| source/_includes/conditions/threshold_value_steps.md | New shared UI step list for “threshold value” conditions. |
| source/_includes/conditions/threshold_value_options_ui.md | New shared UI options block for “threshold value” conditions. |
| source/_includes/conditions/threshold_value_options_yaml.md | New shared YAML options block for “threshold value” conditions. |
c0ffeeca7
reviewed
Jun 3, 2026
Contributor
c0ffeeca7
left a comment
c0ffeeca7
left a comment
There was a problem hiding this comment.
Love it! ❤️ Added a question.
Member
Author
|
@c0ffeeca7 I've replaced the temperature-specific stuff with variables so it each trigger can have the proper descriptions and units. |
c0ffeeca7
approved these changes
Jun 3, 2026
Contributor
c0ffeeca7
left a comment
c0ffeeca7
left a comment
There was a problem hiding this comment.
LGTM, but best to wait for opinions
c0ffeeca7
requested changes
Jun 5, 2026
Contributor
c0ffeeca7
left a comment
c0ffeeca7
left a comment
There was a problem hiding this comment.
A merge conflict appeared. Could you take a look?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Move duplicated parts of the threshold triggers/conditions into a set of shared includes.
Applied it to temperature and humidity. If the approach is approved, we can extend it later to others.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.