Add OpenEVSE button platform#172964
Open
firstof9 wants to merge 2 commits into
Open
Conversation
Contributor
|
Hey there @c00w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds button entity support to the OpenEVSE Home Assistant integration, providing "Restart WiFi" and "Restart EVSE" buttons for the charger.
Changes:
- Added a new
button.pyplatform file with two restart button entities and associated error handling. - Registered
Platform.BUTTONin the integration's__init__.pyand added translation strings for the new entities. - Added comprehensive tests including snapshot, press action, and error handling tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/openevse/__init__.py |
Registers the BUTTON platform in the platforms list. |
homeassistant/components/openevse/button.py |
New platform implementing restart WiFi and restart EVSE button entities. |
homeassistant/components/openevse/strings.json |
Adds translation keys/names for the two button entities. |
tests/components/openevse/test_button.py |
Tests for entity creation, button press, and error handling. |
tests/components/openevse/snapshots/test_button.ambr |
Snapshot data for the button entity tests. |
|
|
||
| async def async_press(self) -> None: | ||
| """Press the button.""" | ||
| with openevse_exception_handler(0.0): |
Comment on lines
+84
to
+92
| self._attr_device_info = DeviceInfo( | ||
| identifiers={(DOMAIN, identifier)}, | ||
| manufacturer="OpenEVSE", | ||
| ) | ||
| if unique_id: | ||
| self._attr_device_info[ATTR_CONNECTIONS] = { | ||
| (CONNECTION_NETWORK_MAC, unique_id) | ||
| } | ||
| self._attr_device_info[ATTR_SERIAL_NUMBER] = unique_id |
8 tasks
Comment on lines
+4
to
+6
| 'aliases': list([ | ||
| None, | ||
| ]), |
c00w
approved these changes
Jun 4, 2026
joostlek
requested changes
Jun 4, 2026
| ), | ||
| OpenEVSEButtonDescription( | ||
| key="restart_evse", | ||
| translation_key="restart_evse", |
Member
There was a problem hiding this comment.
This means restart the device right? we can then omit the translation key as it would follow the device class translation and call it restart
Contributor
Author
There was a problem hiding this comment.
@joostlek There's 2 devices, the underlying EVSE arduino board and the Wifi module for all the API calls.
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR introduces the
buttonplatform to the OpenEVSE integration. It adds support for two reboot/restart buttons:restart_evse())restart_wifi())Both buttons are categorized as configuration entities (
EntityCategory.CONFIG) and utilizeButtonDeviceClass.RESTART.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: