Add new Aqvify integration by astrandb · Pull Request #172936 · home-assistant/core

astrandb · 2026-06-03T17:50:58Z

Proposed change

Add new integration for Aqvify water well and tank level meters. These devices communicates with 4G directly to the cloud and have no contact with LAN.

This integration depends on https://github.com/astrandb/pyaqvify

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Aqvify integration home-assistant.io#45734
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR adds a new Aqvify integration to Home Assistant, enabling cloud-polling-based monitoring of Aqvify water measurement devices via the pyaqvify library.

Changes:

Adds the full Aqvify integration scaffold: config flow, coordinator, sensor platform, base entity, constants, manifest, strings, icons, and quality scale configuration.
Registers the integration in generated files (integrations.json, config_flows.py, CODEOWNERS, requirements_all.txt).
Adds config flow tests with error-handling parametrization and a test fixture in conftest.py.

Reviewed changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
homeassistant/components/aqvify/init.py	Integration setup and teardown entry points
homeassistant/components/aqvify/config_flow.py	Config flow with API key validation
homeassistant/components/aqvify/coordinator.py	Data update coordinator for fetching device data
homeassistant/components/aqvify/entity.py	Base entity class with device info
homeassistant/components/aqvify/sensor.py	Sensor platform for meter value and water level
homeassistant/components/aqvify/const.py	Domain constant
homeassistant/components/aqvify/manifest.json	Integration manifest
homeassistant/components/aqvify/strings.json	UI strings and translations
homeassistant/components/aqvify/icons.json	Entity icon definitions
homeassistant/components/aqvify/quality_scale.yaml	Quality scale checklist
homeassistant/generated/integrations.json	Register integration metadata
homeassistant/generated/config_flows.py	Register config flow
requirements_all.txt	Add pyaqvify dependency
CODEOWNERS	Assign code ownership
tests/components/aqvify/init.py	Test package init
tests/components/aqvify/conftest.py	Test fixtures
tests/components/aqvify/test_config_flow.py	Config flow tests

Copilot

Pull request overview

Copilot reviewed 15 out of 17 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 15 out of 17 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 6 comments.

Copilot

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 21 out of 23 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 21 out of 23 changed files in this pull request and generated 2 comments.

+    'aliases': list([
+      None,
+    ]),


+
+_LOGGER = logging.getLogger(__name__)
+
+UPDATE_INTERVAL = timedelta(seconds=60)


Copilot

Pull request overview

Copilot reviewed 24 out of 26 changed files in this pull request and generated 3 comments.

+    _api = AqvifyAPI(entry.data[CONF_API_KEY], websession=async_get_clientsession(hass))
+    try:
+        await _api.async_get_account_id()
+    except AqvifyAuthException as err:
+        raise ConfigEntryAuthFailed(f"Invalid Aqvify API key: {err}") from err
+    except Exception as err:
+        raise ConfigEntryNotReady(f"Failed to connect to Aqvify API: {err}") from err
+
+    coordinator = AqvifyCoordinator(hass, entry)


home-assistant · 2026-06-08T08:31:59Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copilot

Pull request overview

Copilot reviewed 24 out of 26 changed files in this pull request and generated 3 comments.

+        device_data = {}
+        for device in devices.devices.values():
+            try:
+                device_key = str(device.device_key)
+                device_data[
+                    device_key
+                ] = await self.api_client.async_get_device_latest_data(device_key)
+            except ClientResponseError as err:
+                raise UpdateFailed(
+                    f"Error communicating with Aqvify API: {err}"
+                ) from err
+            except TimeoutError as err:
+                raise UpdateFailed(
+                    f"Timeout communicating with Aqvify API: {err}"
+                ) from err


+  # Platinum
+  async-dependency: todo
+  inject-websession: todo
+  strict-typing: todo


+    'aliases': list([
+      None,
+    ]),


github-actions · 2026-06-08T13:15:55Z

Check requirements

⚠️ Some checks require attention — see the details below.

Package	Old	New	No Advisories	Not Yanked	Repo Public	CI Upload	Release Pipeline	PR Link	Async Safe
pyaqvify	—	0.0.8	✅	✅	✅	✅	✅	❌	✅

📦 pyaqvify: 0.0.8

No Advisories: ✅ No active advisories reported by PyPI for version 0.0.8.
Not Yanked: ✅ Version 0.0.8 is a live (non-yanked) release.
Repo Public: ✅ https://github.com/astrandb/pyaqvify is publicly accessible.
CI Upload: ✅ Trusted Publisher attestation found (GitHub).
Release Pipeline: ✅ OIDC via Trusted Publisher attestation (GitHub); automated CI upload verified by PyPI.
PR Link: ❌ PR description must link to the source repository at https://github.com/astrandb/pyaqvify. A PyPI page link is not sufficient.
Async Safe: ✅ No blocking calls found; all network I/O is performed via aiohttp's async ClientSession.

Generated by Check requirements (AW) · sonnet46 746.4K · ◷

astrandb added 3 commits June 3, 2026 11:32

Initial upload - WIP

46c3e26

Test coverage for config_flow

8d0f84d

Visit quality scale

bab8f8f

Copilot AI review requested due to automatic review settings June 3, 2026 17:50

home-assistant Bot added cla-signed has-tests integration: aqvify new-integration quality-scale labels Jun 3, 2026

Copilot AI reviewed Jun 3, 2026

View reviewed changes

astrandb added 2 commits June 3, 2026 17:52

Remove commented code

82be2db

Follow advice from Copilot

d453d9a

Copilot AI review requested due to automatic review settings June 3, 2026 18:30

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Comment thread homeassistant/components/aqvify/coordinator.py Outdated

Comment thread homeassistant/components/aqvify/config_flow.py Outdated

Comment thread homeassistant/components/aqvify/quality_scale.yaml Outdated

Comment thread tests/components/aqvify/test_config_flow.py Outdated

Follow advice from Copilot

9dc6a0a

This was referenced Jun 4, 2026

Aqvify integration home-assistant/home-assistant.io#45734

Merged

Add brand files for new Aqvify integration home-assistant/brands#10435

Merged

Add tests for second config entry

e56de7d

Copilot AI review requested due to automatic review settings June 4, 2026 08:44

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread homeassistant/components/aqvify/coordinator.py Outdated

Comment thread homeassistant/components/aqvify/coordinator.py Outdated

Comment thread homeassistant/components/aqvify/coordinator.py Outdated

astrandb added 2 commits June 4, 2026 08:59

Adjust wordings

6a61670

Add some tests

4e2f87f

Copilot AI review requested due to automatic review settings June 4, 2026 12:17

Copilot AI reviewed Jun 4, 2026

View reviewed changes

joostlek requested changes Jun 4, 2026

View reviewed changes

astrandb added 2 commits June 4, 2026 12:30

Follow advice from Copilot

2ca90ab

Address review comments

61bbcce

Copilot AI review requested due to automatic review settings June 4, 2026 13:41

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread homeassistant/components/aqvify/config_flow.py Outdated

Comment thread tests/components/aqvify/__init__.py Outdated

Comment thread homeassistant/components/aqvify/sensor.py

astrandb marked this pull request as ready for review June 4, 2026 13:56

astrandb added 4 commits June 4, 2026 15:00

Add account_id to entity unique_id

9984a9f

Change entity icons

b4c495b

Address Copilot comments

53436e2

Add tests for sensor platform

8d1e85e

Copilot AI review requested due to automatic review settings June 4, 2026 18:12

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread tests/components/aqvify/test_init.py Outdated

Comment thread tests/components/aqvify/test_config_flow.py Outdated

astrandb added 2 commits June 4, 2026 18:25

Improve tests

16c80ef

Bump pyaqvify dependency

96dd458

Copilot AI review requested due to automatic review settings June 5, 2026 06:31

Copilot AI reviewed Jun 5, 2026

View reviewed changes

Comment thread tests/components/aqvify/snapshots/test_sensor.ambr

Comment on lines +4 to +6

'aliases': list([

None,

]),

Comment thread homeassistant/components/aqvify/coordinator.py

_LOGGER = logging.getLogger(__name__)

UPDATE_INTERVAL = timedelta(seconds=60)

astrandb added 3 commits June 5, 2026 06:44

Adapt to new pyaqvify interface

642790f

Fixup

dbe4f02

Set strict typing

85e4b59

Copilot AI review requested due to automatic review settings June 5, 2026 09:03

Copilot AI reviewed Jun 5, 2026

View reviewed changes

Cleanup test_config_flow

cf01514

joostlek requested changes Jun 8, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft June 8, 2026 08:31

Address review comments

ccf25b7

Copilot AI review requested due to automatic review settings June 8, 2026 11:47

Copilot AI reviewed Jun 8, 2026

View reviewed changes

astrandb marked this pull request as ready for review June 8, 2026 12:35

home-assistant Bot requested a review from joostlek June 8, 2026 12:35

A few more comments fixed

633908a

joostlek approved these changes Jun 8, 2026

View reviewed changes

joostlek merged commit b8bdd2c into home-assistant:dev Jun 8, 2026
43 of 44 checks passed

github-actions Bot locked and limited conversation to collaborators Jun 9, 2026


		_LOGGER = logging.getLogger(__name__)

		UPDATE_INTERVAL = timedelta(seconds=60)

Uh oh!

Conversation

astrandb commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

astrandb commented Jun 3, 2026 •

edited

Loading