Skip to content

Add AquaRite virtual integration#172331

Open
fdebrus wants to merge 3 commits into
home-assistant:devfrom
fdebrus:aquarite-virtual-integration
Open

Add AquaRite virtual integration#172331
fdebrus wants to merge 3 commits into
home-assistant:devfrom
fdebrus:aquarite-virtual-integration

Conversation

@fdebrus
Copy link
Copy Markdown
Contributor

@fdebrus fdebrus commented May 27, 2026

Breaking change

Proposed change

Hayward Aquarite is one of the OEM-branded pool controllers built on top of Sugar Valley's Vistapool cloud platform (alongside Sugar Valley, Kripsol, and Da-Gen). Per the integration-rename PR (#168051), Aquarite is added as a virtual integration that points users at the Vistapool setup flow, so people searching for "Hayward Aquarite" still land on the right integration.

Brand assets in home-assistant/brands#10385

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Hayward Aquarite is one of the OEM-branded pool controllers built on
top of Sugar Valley's Vistapool cloud platform (alongside Sugar Valley,
Kripsol, and Da-Gen). Per the integration-rename PR (home-assistant#168051), Aquarite
is added as a virtual integration that points users at the Vistapool
setup flow, so people searching for "Hayward Aquarite" still land on
the right integration.

Brand assets in home-assistant/brands#<TBD>.
Copilot AI review requested due to automatic review settings May 27, 2026 09:02
@home-assistant home-assistant Bot added integration: aquarite small-pr PRs with less than 30 lines. labels May 27, 2026
@fdebrus fdebrus changed the title Add Aquarite virtual integration Add AquaRite virtual integration May 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new virtual Home Assistant integration entry for “Hayward AquaRite”.

Changes:

  • Adds aquarite to the generated integrations.json registry.
  • Introduces a new homeassistant/components/aquarite/manifest.json for the virtual integration.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
homeassistant/generated/integrations.json Registers the new aquarite integration in the generated integrations index.
homeassistant/components/aquarite/manifest.json Defines the new virtual integration’s manifest metadata.

Comment thread homeassistant/components/aquarite/manifest.json
Comment thread homeassistant/components/aquarite/manifest.json
@fdebrus fdebrus marked this pull request as ready for review May 27, 2026 10:40
@fdebrus fdebrus marked this pull request as draft June 2, 2026 13:01
@fdebrus fdebrus marked this pull request as ready for review June 2, 2026 13:07
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@home-assistant home-assistant Bot marked this pull request as draft June 4, 2026 18:05
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jun 4, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Required so CI's directory-level mypy/Python checks have a .py file
to scan; matches the krispol virtual integration pattern.
Copilot AI review requested due to automatic review settings June 4, 2026 18:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

@fdebrus fdebrus marked this pull request as ready for review June 4, 2026 18:47
@home-assistant home-assistant Bot requested a review from joostlek June 4, 2026 18:47
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants