Add Unexport ... to hls-export-plugin - #4991
Merged
Merged
Conversation
crtschin
force-pushed
the
crtschin/export-unexport
branch
from
July 14, 2026 22:24
1a19bd5 to
2d91531
Compare
crtschin
changed the title
Unexport ... to hls-export-pluginUnexport ... to hls-export-plugin
crtschin
marked this pull request as ready for review
July 14, 2026 22:46
crtschin
force-pushed
the
crtschin/export-unexport
branch
from
July 15, 2026 16:40
2d91531 to
c5977b6
Compare
fendor
approved these changes
Jul 19, 2026
fendor
left a comment
fendor
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just a quick sanity check not an in-depth review. Please merge once you are happy.
crtschin
force-pushed
the
crtschin/export-unexport
branch
from
July 20, 2026 00:33
0b32b63 to
12d86f0
Compare
crtschin
force-pushed
the
crtschin/export-unexport
branch
from
July 20, 2026 16:14
12d86f0 to
43c4c13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow unexporting symbols using approximately the same machinery as the
Export ...action.This is a bit more finicky than adding exports, so I've not tackled this.