Skip to content

BE-513: HashQL: Rework dynamic aggregate size estimation#8697

Merged
indietyp merged 4 commits into
mainfrom
bm/be-513-hashql-size-estimation-aggregate-cardinality-is-wrong-for
Jun 8, 2026
Merged

BE-513: HashQL: Rework dynamic aggregate size estimation#8697
indietyp merged 4 commits into
mainfrom
bm/be-513-hashql-size-estimation-aggregate-cardinality-is-wrong-for

chore: truncate instead of resize on mul

8c80b95
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 4, 2026 in 0s

59.15% (+0.07%) compared to 91e50f0

View this Pull Request on Codecov

59.15% (+0.07%) compared to 91e50f0

Details

Codecov Report

❌ Patch coverage is 88.67925% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.15%. Comparing base (91e50f0) to head (8c80b95).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...l/mir/src/pass/analysis/size_estimation/dynamic.rs 73.49% 22 Missing ⚠️
...mir/src/pass/analysis/size_estimation/footprint.rs 92.15% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8697      +/-   ##
==========================================
+ Coverage   59.08%   59.15%   +0.07%     
==========================================
  Files        1343     1343              
  Lines      129731   129988     +257     
  Branches     5866     5873       +7     
==========================================
+ Hits        76651    76894     +243     
- Misses      52177    52188      +11     
- Partials      903      906       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.