Skip to content

azuread_group_member - add eventual consistency check for Create #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ic-smiller wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

azuread_group_member - add eventual consistency check for Create #1918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/services/groups/group_member_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,21 @@ func groupMemberResourceCreate(ctx context.Context, d *pluginsdk.ResourceData, m
return tf.ErrorDiagF(err, "Adding %s", id)
}

// Set the ID before waiting, so that a timeout below does not orphan the membership we just created
d.SetId(resourceId.String())

// Wait for membership link to be created
if err := consistency.WaitForUpdate(ctx, func(ctx context.Context) (*bool, error) {
if member, err := groupGetMember(ctx, memberClient, id); err != nil {
return nil, err
} else if member == nil {
return pointer.To(false), nil
}
return pointer.To(true), nil
}); err != nil {
return tf.ErrorDiagF(err, "Waiting for creation of %s", id)
}

return groupMemberResourceRead(ctx, d, meta)
}

Expand Down
Loading