azuread_directory_role_eligibility_schedule_request: handle purged requests - #1904
Open
kenchan0130 wants to merge 3 commits into
Open
azuread_directory_role_eligibility_schedule_request: handle purged requests#1904kenchan0130 wants to merge 3 commits into
kenchan0130 wants to merge 3 commits into
Conversation
azuread_directory_role_eligibility_schedule_request: fix deletion after request cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
Microsoft Graph typically purges
unifiedRoleEligibilityScheduleRequestobjects after 45 days while the corresponding eligible assignment remains.After the request was purged,
terraform applyfailed with:The resource previously depended on retrieving the original request during deletion and assumed that request IDs and schedule IDs were identical.
This change:
roleEligibilityScheduleInstances;Directmember type;adminRemoverequest from Terraform state;roleEligibilityScheduleId;The vendor changes contain the generated Microsoft Graph SDK client required for
roleEligibilityScheduleInstances.Changes to existing Resource / Data Source
Testing
Change Log
azuread_directory_role_eligibility_schedule_request- fix refresh, import, and deletion after the original request is purgedThis is a (please select all that apply):
Related Issue(s)
Follow-up to #1682. Supersedes #1757.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
No changes.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.