Skip to content

fix data race in error logs for replication #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tgross wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −4
Open

fix data race in error logs for replication #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions replication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright IBM Corp. 2013, 2025
// Copyright IBM Corp. 2013, 2026
// SPDX-License-Identifier: MPL-2.0

package raft
Expand All @@ -10,7 +10,7 @@ import (
"sync/atomic"
"time"

"github.com/hashicorp/go-metrics/compat"
metrics "github.com/hashicorp/go-metrics/compat"
)

const (
Expand Down Expand Up @@ -518,7 +518,10 @@ func (r *Raft) pipelineSend(s *followerReplication, p AppendPipeline, nextIdx *u

// Pipeline the append entries
if _, err := p.AppendEntries(req, new(AppendEntriesResponse)); err != nil {
r.logger.Error("failed to pipeline appendEntries", "peer", s.peer, "error", err)
s.peerLock.RLock()
peer := s.peer
s.peerLock.RUnlock()
r.logger.Error("failed to pipeline appendEntries", "peer", peer, "error", err)
return true
}

Expand Down Expand Up @@ -644,7 +647,11 @@ func appendStats(peer string, start time.Time, logs float32, skipLegacy bool) {

// handleStaleTerm is used when a follower indicates that we have a stale term.
func (r *Raft) handleStaleTerm(s *followerReplication) {
r.logger.Error("peer has newer term, stopping replication", "peer", s.peer)
s.peerLock.RLock()
peer := s.peer
s.peerLock.RUnlock()

r.logger.Error("peer has newer term, stopping replication", "peer", peer)
s.notifyAll(false) // No longer leader
asyncNotifyCh(s.stepDown)
}
Expand Down
Loading