feat: Add support for Cygwin#13
Open
VonJagdstrumel wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for Cygwin environments.
Cygwin emulates a native Unix-like system. As a result, the existing logic incorrectly attempts to communicate with KeePassXC via a standard Unix socket. However, the Windows implementation of KeePassXC provides a Win32 named pipe.
To bridge this gap, this change implements a
CygwinPipeclass. By usingos.openwith\\.\pipe\paths, we can interface with the Windows named pipe directly.Why this approach?
pywin32is not easily installable (or often not available at all) under Cygwin's Python distribution.ctypeswrappers to call the Windows API, relying instead on the fact that Cygwin can handle Windows device paths when opened in binary mode.Key Changes
New
CygwinPipeClass:connect,close,sendall,recv).os.openwithos.O_RDWR | os.O_BINARYto interact with the Windows pipe filesystem directly from the Cygwin layer.Platform Detection Logic:
Connectionclass to check forsystem.startswith("CYGWIN_NT").AF_UNIXsocket logic in favor of the newCygwinPipe.Path Resolution:
get_socket_path()to treat Cygwin similarly to Windows, utilizing the named pipe naming convention:org.keepassxc.KeePassXC.BrowserServer_<user>.Global Imports:
import getpassto the top level to ensure availability across all platform branches, as it is now required for both native Windows and Cygwin paths.How to Test
keepassxc_proxy_clientactions.