Skip to content

Backend: Multi RotatingPerk support for Hotx - #6317

Open
AverageUser125 wants to merge 12 commits into
hannibal002:betafrom
AverageUser125:multi-rotate-perk
Open

Backend: Multi RotatingPerk support for Hotx#6317
AverageUser125 wants to merge 12 commits into
hannibal002:betafrom
AverageUser125:multi-rotate-perk

Conversation

@AverageUser125

@AverageUser125 AverageUser125 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

What

The HOTF now got a second rotating perk called "Beekeeper" at hotm 8.
I did not add the perk itself since i ain't got hotm 8 and can't test it.
This PR instead just adds support for multiple RotatingPerks.
I am unsure about the way I implemented this change, but variadic template parameters don't exist in kotlin.

Also HOTF needs a rework since they moved perks and also added a new "powder type", but I don't got enough HOTF exp to attempt that.

Changelog Technical Details

  • Added support for multiple rotating perks. - Avrg

Comment thread src/main/java/at/hannibal2/skyhanni/api/HotmApi.kt Outdated
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Changelog verification failed

Show previous issues

⚠️ Changelog verification failed ⚠️

Detected issues with the pull request description:

Body issues:

  • Change should start with 'Added' instead of 'Add' in text: Add support for multiple rotating perks.

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions Bot added the Wrong Title/Changelog There is an error in the title or changelog label Aug 6, 2026
@github-actions github-actions Bot removed the Wrong Title/Changelog There is an error in the title or changelog label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Detekt found 2 issues

Show previous warnings

⚠️ Detekt found 2 issues ⚠️

  • CurrencyPerHotxPerk.kt:16: Missing trailing comma before ")"
  • HotxHandler.kt:192: Name shadowed: implicit lambda parameter 'it'
More Details
  • CurrencyPerHotxPerk.kt:16
    message: Missing trailing comma before ")"
    rule: detekt.ktlint.TrailingCommaOnDeclarationSite
    path: src/main/java/at/hannibal2/skyhanni/data/hotx/CurrencyPerHotxPerk.kt

  • HotxHandler.kt:192
    message: Name shadowed: implicit lambda parameter 'it'
    rule: detekt.naming.NoNameShadowing
    path: src/main/java/at/hannibal2/skyhanni/data/hotx/HotxHandler.kt

@github-actions github-actions Bot added Detekt Has detekt problem and removed Detekt Has detekt problem labels Aug 6, 2026
@AverageUser125

Copy link
Copy Markdown
Contributor Author

Build failure, but no comment?

@AverageUser125

Copy link
Copy Markdown
Contributor Author
Failed to resolve action download info. Error: Service Unavailable

Github being unstable. nvm.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

❌ Workflow failed ❌

Error message:
Artifact missing - changelog step likely failed before artifact upload

Mode:
changelog

Most likely fix:
merge the beta branch into this PR.

If the issue persists, please ping a maintainer on SkyHanni Discord.

For investigating this error, see [workflow run]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants