Backend: Fishing Hook Display Stop using onTick - #6315
Open
AverageUser125 wants to merge 32 commits into
Open
Conversation
…entChangeEvent.kt Co-authored-by: Luna <lunaynx@gmail.com>
…vents.kt Co-authored-by: Luna <lunaynx@gmail.com>
…vents.kt Co-authored-by: Luna <lunaynx@gmail.com>
…ents.kt Co-authored-by: Luna <lunaynx@gmail.com>
…ents.kt Co-authored-by: Luna <lunaynx@gmail.com>
…ents.kt Co-authored-by: Luna <lunaynx@gmail.com>
…ents.kt Co-authored-by: Luna <lunaynx@gmail.com>
…ents.kt Co-authored-by: Luna <lunaynx@gmail.com>
DependenciesThis PR is now waiting on the following dependency: |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Instead of doing a check each tick, it will see all custom name changes and create the display/renderable once.
If it's there is not known entity it uses the detected one,
if it's the same entity as the previous it just updates,
and if it's a different entity it uses the one closest to the bobber.
I have tested in torrhus, and it works.
(Some users report that it currently randomly stops showing the display like 1h after fishing, but I can't replicate that or prove this fixed it. but I hope the "closest to bobber" logic maybe fixes that)
Changelog Technical Details