Skip to content

Backend: Fishing Hook Display Stop using onTick - #6315

Open
AverageUser125 wants to merge 32 commits into
hannibal002:betafrom
AverageUser125:fishing-hook-display
Open

Backend: Fishing Hook Display Stop using onTick#6315
AverageUser125 wants to merge 32 commits into
hannibal002:betafrom
AverageUser125:fishing-hook-display

Conversation

@AverageUser125

@AverageUser125 AverageUser125 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Dependencies

What

Instead of doing a check each tick, it will see all custom name changes and create the display/renderable once.
If it's there is not known entity it uses the detected one,
if it's the same entity as the previous it just updates,
and if it's a different entity it uses the one closest to the bobber.

I have tested in torrhus, and it works.
(Some users report that it currently randomly stops showing the display like 1h after fishing, but I can't replicate that or prove this fixed it. but I hope the "closest to bobber" logic maybe fixes that)

Changelog Technical Details

  • Improved FishingHookDisplay to only run on entity custom name change instead of each tick. - Avrg

AverageUser125 and others added 30 commits July 26, 2026 16:02
…entChangeEvent.kt

Co-authored-by: Luna <lunaynx@gmail.com>
…vents.kt

Co-authored-by: Luna <lunaynx@gmail.com>
…vents.kt

Co-authored-by: Luna <lunaynx@gmail.com>
…ents.kt

Co-authored-by: Luna <lunaynx@gmail.com>
…ents.kt

Co-authored-by: Luna <lunaynx@gmail.com>
…ents.kt

Co-authored-by: Luna <lunaynx@gmail.com>
…ents.kt

Co-authored-by: Luna <lunaynx@gmail.com>
…ents.kt

Co-authored-by: Luna <lunaynx@gmail.com>
@AverageUser125 AverageUser125 changed the title Backend: Fishing Hook Stop using onTick Backend: Fishing Hook Stop Display using onTick Aug 6, 2026
@github-actions github-actions Bot added the Waiting on Dependency PR waiting for a dependency pr to be merged label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Dependencies

This PR is now waiting on the following dependency:

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Detekt found 1 issue

Show previous warnings

⚠️ Detekt found 1 issue ⚠️

  • CheckRenderEntityEvent.kt:4: Imports must be ordered in lexicographic order with "java", "javax", "kotlin", "kotlinx" and aliases in the end.
More Details
  • CheckRenderEntityEvent.kt:4
    message: Imports must be ordered in lexicographic order with "java", "javax", "kotlin", "kotlinx" and aliases in the end.
    rule: detekt.ImportRules.CustomImportOrdering
    path: src/main/java/at/hannibal2/skyhanni/events/CheckRenderEntityEvent.kt

@github-actions github-actions Bot added the Detekt Has detekt problem label Aug 6, 2026
@github-actions github-actions Bot removed the Detekt Has detekt problem label Aug 6, 2026
@AverageUser125 AverageUser125 changed the title Backend: Fishing Hook Stop Display using onTick Backend: Fishing Hook Display Stop using onTick Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting on Dependency PR waiting for a dependency pr to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant