[dev] refactor devserver into a combined service model#15518
Open
cjllanwarne wants to merge 4 commits into
Open
[dev] refactor devserver into a combined service model#15518cjllanwarne wants to merge 4 commits into
cjllanwarne wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the local devserver to run a single combined proxy that can serve multiple service UIs simultaneously (switching from a SERVICE=... model to service-prefixed URLs like /batch/, /ci/, etc.), and removes the CI MOCK_API_DATA generator path.
Changes:
- Makefile: run all UI watchers + dev proxy together without
SERVICE=..., and require all relevant editable Python packages for devserver startup. - devbin/dev_proxy.py: route by
/<service>/...prefix, register service-prefixed static routes, and configure per-service Jinja environments to avoid template-name conflicts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Makefile | Switch devserver to a combined multi-service target set; update dependency checks and parallelism. |
| devbin/dev_proxy.py | Implement service-prefixed routing/static handling and multi-service Jinja setup; remove SERVICE-based branching and mock-data handler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sarahgibs
approved these changes
Jun 2, 2026
9314bae to
21fd6d6
Compare
grohli
approved these changes
Jun 5, 2026
Contributor
grohli
left a comment
There was a problem hiding this comment.
Discussed and demo shown offline, looks great. Thanks Chris!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Replaces the devserver's
SERVICE=...parameter with a combined service model.Previously:
SERVICE=batch gmake devserverfollowed bylocalhost:8000/Now:
gmake devserverfollowed bylocalhost:8000/batch/Motivation:
At the same time, remove the now redundant
MOCK_API_DATAdata generator that was used to test the flaky tests dashboard.Security Assessment
No prod impact. This is all client-side developer tooling.