Document AsyncFS interface#15478
Open
Eldergenix wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Addresses #14021
This is a documentation-only first pass over the async filesystem API:
AsyncFSinterface and lifecycle expectationsRouterAsyncFSrouting and backend ownership behaviorThis intentionally does not rename methods, change public/private visibility, or convert positional arguments to keyword-only arguments. Those API-boundary changes need compatibility review and can follow separately.
Validation
python3 -m py_compile hail/python/hailtop/aiotools/fs/fs.py hail/python/hailtop/aiotools/router_fs.py hail/python/hailtop/aiocloud/aiogoogle/client/storage_client.py hail/python/hailtop/aiocloud/aioaws/fs.py hail/python/hailtop/aiocloud/aioazure/fs.pygit diff --checkNot run locally:
make -C hail python-version-info/ pytest collection - blocked because this environment has BSD make and nogmake; without generated version files pytest collection fails withModuleNotFoundError: No module named 'hailtop.version'.make check-hail-fast- not run because local ruff/pyright tooling is not installed.Security Assessment
Impact Rating
Impact Description
Documentation-only docstring updates for filesystem interfaces. No runtime behavior, public signatures, deployment code, authentication, authorization, networking, or Batch service paths are changed.