[query] allow attaching debugger to Spark driver JVM#15377
[query] allow attaching debugger to Spark driver JVM#15377patrick-schultz wants to merge 1 commit into
Conversation
ehigham
left a comment
There was a problem hiding this comment.
This is nice, but I have a couple of comments.
I think it would be better to support passing java options instead of these flags. In the past, I've hacked py4j so that I can set JAVA_TOOL_OPTIONS in the envrionment to
- debug two versions of hail side-by-side. This implementation wont work there as the port is already bound by the first
- attach the yourkit profilter
Ideally, I would do something like hl.init(java_opts=['-Xmx8', 'agentlib:blah'])
|
Supporting arbitrary java options makes sense. But since I expect the debugger listening options will be the most used (and they're quite long), I'd like some way to enable that without needing to look up the exact options every time. Likewise, allowing java options to be passed to Other than those desiderata, I don't have strong opinions about the interface for passing java opts. Perhaps something like this covers all the bases?
|
|
If #15395 merges, the test batch for this PR would only have run the following steps: |
Change Description
Introduce an environment variable
HAIL_DEBUG_JVM, which makes the JVM created by py4j or pyspark wait for a remote debugger to attach. Add a note in the dev-docs on how to get this working with IntelliJ.Security Assessment