fix(js): make Document.createEvent reject unknown interface names - #650
Open
zhangyang-crazy-one wants to merge 1 commit into
Open
Conversation
Unknown names now throw a DOMException named NotSupportedError instead of falling back to a generic Event. Event, Events, HTMLEvents and SVGEvents stay explicit aliases for Event. Fixes h4ckf0r0day#610.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unknown interface names passed to Document.createEvent now throw a DOMException named NotSupportedError instead of silently returning a generic Event. The four legacy aliases Event, Events, HTMLEvents and SVGEvents map to a plain Event.
Fixes #610.
Verified with
cargo nextest run -p obscura-js: 283/283 passing, including the updated unknown-type test and new legacy-alias coverage.