fix(render): clip outset box shadows - #646
Open
lisa0314 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validation
cargo nextest run --release --features paint -p obscura-render --no-fail-fast: 580 passed, 1 skippedcargo nextest run --release --features render -p obscura-cli --test box_shadow_screenshot: 1 passedcargo nextest run --release --features render --no-fail-fast: 1408 passed, 4 skippedcargo build --release -p obscura-cli --bins --no-default-featurescargo build --release -p obscura-cli --bins --features rendergit diff --checkRendering
render-repros/box-shadow-outset.htmlproduced a nonblank image with the expected transparent interiorsquotes.toscrape.comcapture kept quote interiors readable and shadows outside their boxesPerformance
Each shadow uses a temporary surface bounded by its visible ink rather than a full-viewport mask. Five same-fixture CLI captures showed no visible latency regression. Excluding the first process startup, the baseline median was about 22.2 ms and the candidate median was about 20.4 ms. This is treated only as a regression check, not as a speedup claim.
Checklist
Fixes #641.