fix(cli): enforce --obey-robots - #645
Open
lisa0314 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
--obey-robotsa global option and apply it tofetchandscrape/robots.txtper URL origin, including non-default portsValidation
cargo nextest run --release --features render -p obscura-cli --test obey_robots --no-fail-fast: 4 passedcargo nextest run --release --features render -p obscura-net -p obscura-browser -p obscura-cli --no-fail-fast: 212 passedcargo build --release -p obscura-cli --bins --no-default-featurescargo build --release -p obscura-cli --bins --features rendergit diff --checkRendering
Not applicable. The change affects CLI option handling and network request policy, not layout, paint, screenshots, or rendering fixtures.
Performance
No standalone CPU or memory benchmark was run. The default disabled path retains its previous behavior. When enabled, robots rules and empty policy results are cached per full URL origin so repeated targets do not refetch the same policy.
Checklist
Fixes #642.