fix(js): reject unknown createEvent interfaces - #611
Open
xrip wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotSupportedErrorfor unknownDocument.createEventinterface names instead of returning a genericEventEvent,Events,HTMLEvents, andSVGEventsexplicit aliasesHashChangeEventandMessageEventconstructorsThe DOM createEvent algorithm requires an unknown name, or a listed interface that is not exposed on the current global, to throw
NotSupportedError.Fixes #610
Verification
origin/maincreateEventtests: 5/5 passedobscura-js: 367/367 passedobscura-js: 281/281 passedmax_connections_refuses_then_recoversfailed; it also fails on the unchanged Windows baseline and is tracked by Windows connection refusal resets before the 503 response is read #604 with a fix in fix(cdp): deliver connection refusal response #605render,render,stealth, no default features, and no default features plusstealthNotSupportedErrorDOMException, all four aliases, and theHashChangeEventandMessageEventclasses