[WIP] Fixed #18554: Custom Component Report#19145
Open
marcusmoore wants to merge 115 commits into
Open
Conversation
This reverts commit c14cd27.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| UnusedCode | 1 medium |
| BestPractice | 1 medium |
| CodeStyle | 1 minor |
| Complexity | 2 medium |
🟢 Metrics 130 complexity
Metric Results Complexity 130
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the Custom Component Report that works similar to the Custom Asset Report.
A couple more things to do before marking this as ready for review:
How to Access
By clicking the button on the component index page:
Via the reports index
Via the navigation menu:
The Report
Default
By default the report will return one row per component like expected.
Including Assignments
By checking
Include Assignmentsthe report will write rows for each component's qty and include the details about the assigned asset as well.Other Details
Livewire component for template selector
I extracted this into a livewire component since I was copying and pasting it to different places:
AI Usage Disclosure
I used AI in a few places but most of this code is "hand" written. The biggest usage was having it convert a long chunk of
ifstatements into thebuildMappingmethod in the controller.Fixes #18554