Fixed #18907 - Change default queue, make all notifications queable.#19126
Draft
uberbrady wants to merge 1 commit into
Draft
Fixed #18907 - Change default queue, make all notifications queable.#19126uberbrady wants to merge 1 commit into
uberbrady wants to merge 1 commit into
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 10 medium |
🟢 Metrics 0 complexity
Metric Results Complexity 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Member
Author
|
@bzeus can you test out this branch and see if notifications work correctly? Dankeshein! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18907
Changes the default driver to 'background' which runs after the page has rendered. Doesn't require any DB tables, but if someothing in the message-sending system fails, the remaining messages will probably not get sent.
This is written without any tests to handle anything or even any physical testing. Just trying to show the way I would be going (and possibly, how we've gone) if we adopt this approach.