🖼️ Fixed #18973 - Added error state renderer to show a different message if 500 is returned

[snipe]

This shows a specific error if the API is returning a 500, versus just "no results". I've tested this on initial page load (I changed the users API index query to query for users.gaddress instead of users.address to force a 500 response) and also search and advanced search.

Fixes #18973

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[uberbrady]

This is going to be great! We’ve definitely had issues in the past with customers and open-source users “freaking out” because they had “no records” - when in reality they just forgot to run migrations during an upgrade.

But one very big concern I have is the number of retries - 80 seems awfully high. If we did have a bug somewhere, and accidentally rolled it out into production (not super-likely, but not impossible), we would absolutely melt our servers with that number of retries I fear.

I’m not sure of the exact number of retries we should be attempting, but I’m thinking not much more than single-digits. Happy to hash that out with you to figure out exactly how many we want to do.

[uberbrady]

I want to take a swing at cleaning this up a little, it feels a little bit all-over-the-place. But if this, how it is, is how it has to be, I'll at least want to inject a bunch of comments explaining why we're having to do these things in all of these different places.

[snipe]

Totally fair. The BS tables code is pretty crazy, because we have a bunch of things that have to happen in a certain order, and then sometimes have to re-render afterwards (think the tooltips, etc). If you can find a cleaner way to do this, I'm 100% on board and will not be the least bit salty. I hate this code too, but everything else I tried sucked worse.

[snipe]

ALSO - if you do take a stab at this, remember that you have to test a buttload of other things to make sure they don't break, and they're all manual tests, since the UI testing we have won't be able to render the BS table space like a normal browser would. (We see this in the pa11y testing too - no matter how long I set the delay, the screenshots are always "table loading")

Off the top of my head:

• column selection via the table toolbar
• column name searching on that column selector (I think that's only on assets)
• custom toolbar buttons (look for the yellow "+" icon as a quick check)
• advanced search behaving the new way (with the tags that show up and can be deleted, etc)
• sticky columns
• tooltips
• modals for delete actions
• column sorting
• regular search highlighting the matches
• ALLLLL of that above behavior on pages that have multiple tables on them, via tabbed UI or otherwise

I already tested those things with my version, so you'll have to make sure nothing you do breaks that functionality.