Adds #9557 Expiring Items Report to GUI: Assets and Licenses#18723
Adds #9557 Expiring Items Report to GUI: Assets and Licenses#18723Godmartinz wants to merge 17 commits into
Conversation
|
Handling conflicts |
# Conflicts: # app/Http/Controllers/Api/ReportsController.php # app/Models/License.php # app/Providers/BreadcrumbsServiceProvider.php # resources/lang/en-US/general.php
|
odd fail for php 8.2 🤔 EDIT: Looks like it was a fluke. |
Godmartinz
changed the title
Godmartinz
changed the title
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
Can we add tests for those new routes? At least for permissions.
|
Can you also catch this up to develop and run pint? |
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
One question to make sure we don't break the existing use of scopeExpiringLicenses but other than that 👍🏾
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
One thing to remove but looks good otherwise 👍🏾
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 21 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
# Conflicts: # routes/api.php # routes/web.php
|
Can you resolve these conflicts? Once that's done, I think we're GTG |
# Conflicts: # app/Http/Controllers/Api/ReportsController.php # routes/api.php
|
@snipe conflicts should be resolved. 🤞 |
|
Looks like we have some failing tests here |
3 participants
This adds a new 'Expiring Items Report' page with Tabs showing Assets and Licenses that are set to expire or terminate:
This info is loaded using API controller and routes
reports/expiring-assetsreports/expiring-licensesCSV Tables:
Adds: #9557