Skip to content

feat: refactor column detection#62

Open
niktverd wants to merge 4 commits into
mainfrom
feat/refactor_column_detection
Open

feat: refactor column detection#62
niktverd wants to merge 4 commits into
mainfrom
feat/refactor_column_detection

Conversation

@niktverd

@niktverd niktverd commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@niktverd niktverd requested a review from NikitaCG as a code owner June 7, 2023 09:16
@gravity-ui-bot

Copy link
Copy Markdown
Contributor

Preview is ready.

@NikitaCG NikitaCG requested a review from gorgeousvlad June 9, 2023 09:54
Comment thread src/constructor/blocksMap.ts Outdated

return blocks;
},
{} as Record<string, unknown>,

@NikitaCG NikitaCG Jun 9, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we can use React.FC<> instead unknown in this type?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@NikitaCG

NikitaCG commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

@gorgeousvlad we need your look)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants