Skip to content

feat: verify DIPs proposal manifest network is supported#1043

Draft
MoonBoi9001 wants to merge 1 commit into
mb9/add-dips-grpc-reject-reasonsfrom
mb9/verify-dips-manifest-network-is-supported
Draft

feat: verify DIPs proposal manifest network is supported#1043
MoonBoi9001 wants to merge 1 commit into
mb9/add-dips-grpc-reject-reasonsfrom
mb9/verify-dips-manifest-network-is-supported

Conversation

@MoonBoi9001
Copy link
Copy Markdown
Member

TL;DR

Makes the indexer check a DIPs proposal's network against its configured DIPs networks at the manifest step, and treats a manifest with an empty network field as malformed. Small hardening change, stacked on #1041.

Motivation

When the indexer receives a DIPs proposal it fetches the subgraph manifest and reads the network the subgraph indexes. Today it never checks that network against the operator's configured DIPs networks directly — an unconfigured network is only caught later and indirectly, when the price lookup happens to find no minimum for it, and a manifest whose network field is empty slips through that gap entirely.

This adds an explicit check at the manifest step: a network the operator hasn't configured for DIPs is rejected up front with the unsupported-network reason, and an empty network field is reported as a malformed manifest rather than masquerading as an unsupported network.

Summary

  • Check the manifest's network against the indexer's configured DIPs networks at the manifest step.
  • Reject a manifest with an empty network field as malformed, not as an unsupported network.
  • A genuinely unsupported network behaves as before, just caught earlier and explicitly.
  • A malformed manifest still maps to the generic "other" reason on the wire (no new wire code here).
  • Add a unit test covering the empty-network case.
  • Stacked on feat: classify DIPs proposal rejections by area and nature #1041; rebase onto main-dips-rebased once that merges.

@graphprotocol graphprotocol deleted a comment from github-actions Bot Jun 5, 2026
@MoonBoi9001 MoonBoi9001 force-pushed the mb9/add-dips-grpc-reject-reasons branch from 0b4c34e to ca26d2b Compare June 5, 2026 14:00
The indexer reads a proposal's network from the subgraph manifest but only rejected an unconfigured
network indirectly, when the price lookup later missed it, and an empty network field slipped through.
Check the network against the indexer's configured DIPs networks up front, and reject an empty one.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@MoonBoi9001 MoonBoi9001 force-pushed the mb9/verify-dips-manifest-network-is-supported branch from 19ff9b9 to d920526 Compare June 5, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant