Skip to content

feat: add prebuilt native asset hook support#275

Closed
HamdaanAliQuatil wants to merge 2 commits into
masterfrom
native-prebuilt-assets
Closed

feat: add prebuilt native asset hook support#275
HamdaanAliQuatil wants to merge 2 commits into
masterfrom
native-prebuilt-assets

Conversation

@HamdaanAliQuatil

Copy link
Copy Markdown
Collaborator

No description provided.

@HamdaanAliQuatil
HamdaanAliQuatil requested a review from jonasfj June 22, 2026 18:36
Comment thread prebuilt/README.md

These binaries should be generated by maintainer-triggered CI from merged
source, then committed by a maintainer. They should not be accepted from
user-authored PRs.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to highlight alternative options, in no particular order.

  • (A) We build prebuilt/ as part of the automated publishing job, they are always build github actions and published inside the package to pub.dev
  • (B) We build prebuilt/ and upload as artifacts on the github release we create when we create a new version, the hook will then have to download these from github releases.
  • (C) We build prebuilt/ and then commit them to git.

(C) has the downside that repository size will increase significantly over time, especially if we add more architectures/platforms.

(A) has the downside that download size of users will increase, but not that much. pub.dev will refuse packages larger than 100mb or 200mb (I don't recall the exact limits), but we'll probably be okay unless we add many architectures.


If we can build the artifacts in github CI, then perhaps (A) is attractive? We also avoid maintainer churn and avoid having to store binary artifacts in github.

@mosuem

mosuem commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

@HamdaanAliQuatil I filed #325, based on package:icu4xs existing infrastructure. Would you be fine with leaving a review on that PR and me closing this one?

@HamdaanAliQuatil

Copy link
Copy Markdown
Collaborator Author

Thanks for picking this up @mosuem . Yes, please close this PR since the implementation here is stale.

I resumed the work in #315 after Jonas’s feedback and moved prebuilt generation into the existing pub.dev publishing workflow. #325 uses the alternative GitHub Release fetch model, so it does not directly supersede #315. I’ll leave a review there so we can settle which distribution model we want before either implementation goes further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants