Conversation
- Clear `self._transfer_service` to avoid invalid C++ calls during shutdown. Change-Id: Ifcd54ff898de560d52374c0e54b38ef4d74e6adf
Python Code Coverage Summary
Minimum allowed line rate is |
C++ Code Coverage Summary
Minimum allowed line rate is |
Leahlijuan
approved these changes
May 5, 2026
g-husam
reviewed
May 5, 2026
| _LOGGER.info("Shutting down ReplicationManager and TransferService...") | ||
| if self._transfer_service: | ||
| self._transfer_service.shutdown() | ||
| self._transfer_service = None |
Collaborator
There was a problem hiding this comment.
was discussing with @Leahlijuan last week - not sure if this truly fixes the problem, since there will still be ongoing requests, this just wont allow new requests.
We need to deterministically prevent any replication on train end, or wait for it all to finish, to fully fix this I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear
self._transfer_serviceto avoid invalid C++ calls during shutdown.