Move common-util and common-deps dependencies to a version catalog#3026
Open
KlyneChrysler wants to merge 1 commit into
Open
Move common-util and common-deps dependencies to a version catalog#3026KlyneChrysler wants to merge 1 commit into
KlyneChrysler wants to merge 1 commit into
Conversation
KlyneChrysler
requested review from
hfmehmed,
jaschdoc and
troelsbjerre
as code owners
First slice of google#2968, migrating module-by-module as discussed in google#2989. Introduces gradle/libs.versions.toml with kotlin-stdlib and junit; junitVersion and kotlinBaseVersion stay in gradle.properties while other modules still read them.
KlyneChrysler
force-pushed
the
build/2968-catalog-01-common
branch
from
bd04c91 to
43622d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of #2968, following the guidance in #3025 and #2989 to migrate module by module with only a couple of dependencies at a time.
This introduces gradle/libs.versions.toml with kotlin-stdlib and junit, and switches common-util and common-deps to catalog accessors. Nothing is removed from gradle.properties yet because other modules still read those properties.
Verified locally with ./gradlew :common-util:compileTestKotlin :common-deps:compileTestKotlin.
The remaining modules are prepared as equally small follow-up slices and I will submit them one at a time as each PR lands, so every review stays small.