Skip to content

Allow collection-backed annotation array values in regression test #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yong-yuan-X wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow collection-backed annotation array values in regression test #3023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6db3a4a
Allow collection-backed annotation array values in regression test
Yong-yuan-X Jul 7, 2026
da137a5
Move annotation array value test into KSPUnitTestSuite
Yong-yuan-X Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...pi/src/test/kotlin/com/google/devtools/ksp/processor/AnnotationArrayValueTypeProcessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ class AnnotationArrayValueTypeProcessor : AbstractTestProcessor() {
val argument = annotation.arguments.single()
val value = argument.value
val argumentName = argument.name?.asString()
results.add("$className $annotationName $argumentName is Array<*>: ${value is Array<*>}")
check(value is Array<*> || value is Collection<*>) {
"Unexpected array-valued annotation argument type: ${value?.javaClass?.name ?: "null"}"
}
results.add("$className $annotationName $argumentName is Array<*> or Collection<*>: true")
results.add("$className $annotationName $argumentName size: ${value.sizeOrNull()}")
}
}
Expand Down
6 changes: 0 additions & 6 deletions ...in-analysis-api/src/test/kotlin/com/google/devtools/ksp/test/AAConfiguredUnitTestSuite.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ class AAConfiguredUnitTestSuite : KSPUnitTestSuite(experimentalPsiResolution = f
runTest("$AA_PATH/getSymbolsWithAnnotation/aliasedAnnotation.kt")
}

@TestMetadata("annotationArrayValueType.kt")
@Test
override fun testAnnotationArrayValueType() {
runFailingTest("$AA_PATH/annotationArrayValueType.kt")
}

@TestMetadata("allUseSiteTargetAppliedToAnnotationList.kt")
@Test
override fun testAllUseSiteTargetAppliedToAnnotationList() {
Expand Down
6 changes: 5 additions & 1 deletion kotlin-analysis-api/src/test/kotlin/com/google/devtools/ksp/test/KSPUnitTestSuite.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,11 @@ abstract class KSPUnitTestSuite(
}

@Bug("https://github.com/google/ksp/issues/3008", BugState.OPEN)
abstract fun testAnnotationArrayValueType()
@TestMetadata("annotationArrayValueType.kt")
@Test
fun testAnnotationArrayValueType() {
runTest("$AA_PATH/annotationArrayValueType.kt")
}

@TestMetadata("annotationWithDefault.kt")
@Test
Expand Down
6 changes: 0 additions & 6 deletions ...n-analysis-api/src/test/kotlin/com/google/devtools/ksp/test/PsiConfiguredUnitTestSuite.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ class PsiConfiguredUnitTestSuite : KSPUnitTestSuite(experimentalPsiResolution =
runFailingTest("$AA_PATH/getSymbolsWithAnnotation/aliasedAnnotation.kt")
}

@TestMetadata("annotationArrayValueType.kt")
@Test
override fun testAnnotationArrayValueType() {
runFailingTest("$AA_PATH/annotationArrayValueType.kt")
}

@TestMetadata("allUseSiteTargetAppliedToAnnotationList.kt")
@Test
override fun testAllUseSiteTargetAppliedToAnnotationList() {
Expand Down
8 changes: 4 additions & 4 deletions kotlin-analysis-api/testData/annotationArrayValueType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
*/
// TEST PROCESSOR: AnnotationArrayValueTypeProcessor
// EXPECTED:
// JavaAnnotated JavaAnnotation args is Array<*>: true
// JavaAnnotated JavaAnnotation args is Array<*> or Collection<*>: true
// JavaAnnotated JavaAnnotation args size: 2
// JavaAnnotated KotlinAnnotation args is Array<*>: true
// JavaAnnotated KotlinAnnotation args is Array<*> or Collection<*>: true
// JavaAnnotated KotlinAnnotation args size: 2
// KotlinAnnotated JavaAnnotation args is Array<*>: true
// KotlinAnnotated JavaAnnotation args is Array<*> or Collection<*>: true
// KotlinAnnotated JavaAnnotation args size: 2
// KotlinAnnotated KotlinAnnotation args is Array<*>: true
// KotlinAnnotated KotlinAnnotation args is Array<*> or Collection<*>: true
// KotlinAnnotated KotlinAnnotation args size: 2
// END
// FILE: JavaAnnotation.java
Expand Down
Loading