Add backing fields to KSP API#2969
Open
jaschdoc wants to merge 10 commits into
Open
Conversation
jaschdoc
force-pushed
the
backing-fields2873
branch
14 times, most recently
from
6d41cde to
983e328
Compare
jaschdoc
force-pushed
the
backing-fields2873
branch
9 times, most recently
from
3810e2a to
21f29e8
Compare
jaschdoc
force-pushed
the
backing-fields2873
branch
2 times, most recently
from
44239e4 to
77e93b8
Compare
jaschdoc
force-pushed
the
backing-fields2873
branch
from
4b85fb9 to
8d915ce
Compare
These tests use Room which does not yet support backing fields.
jaschdoc
force-pushed
the
backing-fields2873
branch
from
8d915ce to
2305a36
Compare
Collaborator
Author
|
I have ignored the integration tests that include Room. I'm working on submitting a fix for Room, but the problem is circular, since Room depends on KSP, and our tests depend on Room. Thus, the tests should be disabled until Room has the proper fix and then we can update our tests to use the fixed version of Room and re-enable the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MutableList<String>Closes #2873