Add --gerrit-unsafe-dont-check-for-dups.#349
Open
prbprbprb wants to merge 1 commit into
Open
Conversation
Hope you can merge this - it is for a very local situation (Gerrit with no service account available and only SSH access feasible), but it's useful for anyone else in this situation and explicitly marked as unsafe to minimise footgun potential. Option skips querying Gerrit for the internal copybara hashtag for an existing open change before creating one. Lets git.gerrit_destination run with no Gerrit REST calls needed. Cost: each run mints a fresh Change-Id which are _mostly_ stable but there's no belt and braces dup checking so you might get duplicate Gerrit CLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope you can merge this - it is for a very local situation (Gerrit with no service account available and only SSH access feasible), but it's useful for anyone else in this situation and explicitly marked as unsafe to minimise footgun potential.
Option skips querying Gerrit for the internal copybara hashtag for an existing open change before creating one. Lets git.gerrit_destination run with no Gerrit REST calls needed.
Cost: each run mints a fresh Change-Id which are mostly stable but there's no belt and braces dup checking so you might get duplicate Gerrit CLs.